This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix: update generated proto types; fix the update script#1825
Merged
alexander-fenster merged 1 commit intomainfrom Feb 17, 2023
Merged
fix: update generated proto types; fix the update script#1825alexander-fenster merged 1 commit intomainfrom
alexander-fenster merged 1 commit intomainfrom
Conversation
product-auto-label
Bot
added
size: xl
MarkDuckworth
approved these changes
Feb 17, 2023
MarkDuckworth
added a commit
that referenced
this pull request
Feb 17, 2023
* OR operator support and integration tests. * Updating documentation and member visibility. * Remove usage of OPERATOR_UNSPECIFIED standing in for OR. * Removing private and internal tags from OR query public API members. * Ensure that new OR Query features are in firestore.d.ts and are exported from the main entry point. * Update documentation for OR query features to match android PR 4274. * Removing CompositeFilter and UnaryFilter from the type definitions and JS doc. * Corrected the descending order test for OR queries. * fix: update generated proto types; fix the update script (#1825) * Adding OR enum value for composit filter operator. --------- Co-authored-by: Alexander Fenster <[email protected]>
ehsannas
pushed a commit
that referenced
this pull request
Mar 6, 2023
* WIP: OR Query with unit tests. No OR operator. * Updating documentation and member visibility. * Formatting * Skipping OR Query system test. * Updated copyright holder for new files. * PR fixes. * feat: OR Query support (#1801) * OR operator support and integration tests. * Updating documentation and member visibility. * Remove usage of OPERATOR_UNSPECIFIED standing in for OR. * Removing private and internal tags from OR query public API members. * Ensure that new OR Query features are in firestore.d.ts and are exported from the main entry point. * Update documentation for OR query features to match android PR 4274. * Removing CompositeFilter and UnaryFilter from the type definitions and JS doc. * Corrected the descending order test for OR queries. * fix: update generated proto types; fix the update script (#1825) * Adding OR enum value for composit filter operator. --------- Co-authored-by: Alexander Fenster <[email protected]> * Updating header copyright to 2023 * Tests that require an index are configured to only run against the emulator. * Test cleanup based on PR comments. --------- Co-authored-by: Alexander Fenster <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added one new proto dependency to
dev/protos/update.sh, fixed it so that it ran regardless of the current working directory. Updated the generated.d.tsand.jsonfiles.