This repository was archived by the owner on Mar 4, 2026. It is now read-only.
patch: ensure that the client pool consistently uses grpc clients after transitioning from rest#1807
Merged
MarkDuckworth merged 5 commits intomainfrom Jan 3, 2023
Conversation
…, so that the client pool consistently uses grpc after the transition, rather than occasionally reverting back to REST.
product-auto-label
Bot
added
size: m
ehsannas
approved these changes
Dec 27, 2022
Contributor
ehsannas
left a comment
ehsannas
left a comment
There was a problem hiding this comment.
Thanks for the test coverage!
ehsannas
reviewed
Dec 27, 2022
MarkDuckworth
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch: Ensure that the client pool consistently uses gRPC clients after transitioning from REST. Previously there were some edge cases where the client pool may create a REST client after it had transitioned to gRPC. Additionally, API docs were added for preferRest.
BEGIN_COMMIT_OVERRIDE
fix: Ensure that the client pool consistently uses gRPC clients after transitioning from REST
END_COMMIT_OVERRIDE