Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

fix: fix duplicates in Query.stream() with back pressure#1806

Merged
dconeybe merged 3 commits intomainfrom
dconeybe/DuplicateDocFixIssue1790_Squashed
Jan 3, 2023
Merged

fix: fix duplicates in Query.stream() with back pressure#1806
dconeybe merged 3 commits intomainfrom
dconeybe/DuplicateDocFixIssue1790_Squashed

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

Fixes #1790

Googlers see b/255772813 for some extra context.

@dconeybe dconeybe added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Dec 20, 2022
@dconeybe dconeybe self-assigned this Dec 20, 2022
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Dec 20, 2022
@dconeybe dconeybe marked this pull request as ready for review December 20, 2022 14:19
@dconeybe dconeybe requested review from a team and MarkDuckworth December 20, 2022 14:19
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
Comment thread dev/test/query.ts
Copy link
Copy Markdown
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 duplicate documents from query.stream after retry

2 participants