Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: Add OR query support#1803

Merged
MarkDuckworth merged 2 commits intomainfrom
owl-bot-copy
Feb 16, 2023
Merged

feat: Add OR query support#1803
MarkDuckworth merged 2 commits intomainfrom
owl-bot-copy

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Dec 6, 2022 •
edited by MarkDuckworth
Loading

  • Regenerate this pull request now.

docs: Improve the API documentation for the Firestore.ListDocuments RPC
docs: Minor documentation formatting and cleanup

PiperOrigin-RevId: 509631855

Source-Link: googleapis/googleapis@22bd888

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8b14516619c48e1ddabcec1aec55ac0257364102
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGIxNDUxNjYxOWM0OGUxZGRhYmNlYzFhZWM1NWFjMDI1NzM2NDEwMiJ9

docs: changing format of the jsdoc links

PiperOrigin-RevId: 509352615

Source-Link: googleapis/googleapis@b737d30

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8efadf3d58780ea1c550268d46a3dc701ba37fcf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVmYWRmM2Q1ODc4MGVhMWM1NTAyNjhkNDZhM2RjNzAxYmEzN2ZjZiJ9

chore(gitignore): only ignore folders in the top level

PiperOrigin-RevId: 507603203

Source-Link: googleapis/googleapis@a4f2de4

Source-Link: https://github.com/googleapis/googleapis-gen/commit/dcf882154e7c710ecf2a1abc77b35c95f9062371
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGNmODgyMTU0ZTdjNzEwZWNmMmExYWJjNzdiMzVjOTVmOTA2MjM3MSJ9

chore: update .gitignore to always include protos folder

Use gapic-generator-typescript v3.0.0.

PiperOrigin-RevId: 507004755

Source-Link: googleapis/googleapis@d784f3c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/5e64ba8615f65fdedb1fcd6ac792e5ea621027e4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWU2NGJhODYxNWY2NWZkZWRiMWZjZDZhYzc5MmU1ZWE2MjEwMjdlNCJ9

chore: Disable requesting numeric enums in "transport=rest" responses for nodejs-firestore

PiperOrigin-RevId: 502893047

Source-Link: googleapis/googleapis@6adf7b1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/bf897a567eb8552599854de00308b38b08fe62d9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY4OTdhNTY3ZWI4NTUyNTk5ODU0ZGUwMDMwOGIzOGIwOGZlNjJkOSJ9

feat: Added SuggestConversationSummary RPC
docs: updated go library package

PiperOrigin-RevId: 501862436

Source-Link: googleapis/googleapis@155e0f4

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3051f617a991c274c88d27064e803095e4ef9d39
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzA1MWY2MTdhOTkxYzI3NGM4OGQyNzA2NGU4MDMwOTVlNGVmOWQzOSJ9

chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9

BEGIN_COMMIT_OVERRIDE

docs: Improve the API documentation for the Firestore.ListDocuments RPC
docs: Minor documentation formatting and cleanup
docs: changing format of the jsdoc links
chore: Added SuggestConversationSummary RPC protos
chore: Add OR Query RPC protos

END_COMMIT_OVERRIDE

@gcf-owl-bot gcf-owl-bot Bot requested review from a team December 6, 2022 01:11
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Dec 6, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@MarkDuckworth MarkDuckworth added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Dec 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Dec 13, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2022
@MarkDuckworth MarkDuckworth added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 19, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Dec 19, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 19, 2022
@MarkDuckworth MarkDuckworth added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 21, 2022
@MarkDuckworth
Copy link
Copy Markdown
Contributor

MarkDuckworth commented Dec 21, 2022

@alexander-fenster, it looks like the change to support numeric enums in REST caused a regression in Firestore. Specifically the tests lists missing documents is failing. Since the test seems to be consistently failing only when using REST, I'm considering that there may be a regression. I haven't had a chance to dig in yet, but I'm tagging you now just for awareness.

@gcf-owl-bot gcf-owl-bot Bot changed the title chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport feat: Added SuggestConversationSummary RPC Jan 13, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@MarkDuckworth MarkDuckworth removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 25, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 25, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 25, 2023
@MarkDuckworth MarkDuckworth added the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2023
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Jan 25, 2023

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2023
@gcf-owl-bot gcf-owl-bot Bot changed the title chore: Disable requesting numeric enums in "transport=rest" responses for nodejs-firestore chore: update .gitignore to always include protos folder Feb 4, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 4, 2023
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Feb 4, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2023
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Feb 4, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2023
@gcf-owl-bot gcf-owl-bot Bot changed the title chore: update .gitignore to always include protos folder chore(gitignore): only ignore folders in the top level Feb 7, 2023
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Feb 7, 2023
@gcf-owl-bot
Copy link
Copy Markdown
Contributor Author

gcf-owl-bot Bot commented Feb 16, 2023

Owl bot is regenerating pull request 1803...
Build name: NDNiYmM1Y2MtOTk0YS00NmM4LWIxZjktMjEzZWExYWRhMTIy

gcf-owl-bot Bot added 2 commits February 16, 2023 18:21
@gcf-owl-bot
feat: Add OR query support
23aef42 
docs: Improve the API documentation for the `Firestore.ListDocuments` RPC
docs: Minor documentation formatting and cleanup

PiperOrigin-RevId: 509631855

Source-Link: googleapis/googleapis@22bd888

Source-Link: googleapis/googleapis-gen@8b14516
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGIxNDUxNjYxOWM0OGUxZGRhYmNlYzFhZWM1NWFjMDI1NzM2NDEwMiJ9

docs: changing format of the jsdoc links

PiperOrigin-RevId: 509352615

Source-Link: googleapis/googleapis@b737d30

Source-Link: googleapis/googleapis-gen@8efadf3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVmYWRmM2Q1ODc4MGVhMWM1NTAyNjhkNDZhM2RjNzAxYmEzN2ZjZiJ9

chore(gitignore): only ignore folders in the top level

PiperOrigin-RevId: 507603203

Source-Link: googleapis/googleapis@a4f2de4

Source-Link: googleapis/googleapis-gen@dcf8821
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGNmODgyMTU0ZTdjNzEwZWNmMmExYWJjNzdiMzVjOTVmOTA2MjM3MSJ9

chore: update .gitignore to always include protos folder

Use gapic-generator-typescript v3.0.0.

PiperOrigin-RevId: 507004755

Source-Link: googleapis/googleapis@d784f3c

Source-Link: googleapis/googleapis-gen@5e64ba8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWU2NGJhODYxNWY2NWZkZWRiMWZjZDZhYzc5MmU1ZWE2MjEwMjdlNCJ9

chore: Disable requesting numeric enums in "transport=rest" responses for nodejs-firestore

PiperOrigin-RevId: 502893047

Source-Link: googleapis/googleapis@6adf7b1

Source-Link: googleapis/googleapis-gen@bf897a5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY4OTdhNTY3ZWI4NTUyNTk5ODU0ZGUwMDMwOGIzOGIwOGZlNjJkOSJ9

feat: Added SuggestConversationSummary RPC
docs: updated go library package

PiperOrigin-RevId: 501862436

Source-Link: googleapis/googleapis@155e0f4

Source-Link: googleapis/googleapis-gen@3051f61
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzA1MWY2MTdhOTkxYzI3NGM4OGQyNzA2NGU4MDMwOTVlNGVmOWQzOSJ9

chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: googleapis/googleapis-gen@78bd8f0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
74dfe9a 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@release-please release-please Bot mentioned this pull request Feb 16, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. owl-bot-copy size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MarkDuckworth @alexander-fenster @sofisl @tom-andersen @yoshi-kokoro