This repository was archived by the owner on Mar 4, 2026. It is now read-only.
feat: OR Query support#1801
Merged
MarkDuckworth merged 16 commits intomarkduckworth/or-queriesfrom Feb 17, 2023
Merged
Conversation
product-auto-label
Bot
added
size: l
ehsannas
reviewed
Nov 29, 2022
ehsannas
reviewed
Nov 29, 2022
Contributor
ehsannas
left a comment
ehsannas
left a comment
There was a problem hiding this comment.
LGTM. Will take a second look / approve whenever we can actually merge the PR
ehsannas
reviewed
Dec 21, 2022
ehsannas
reviewed
Dec 21, 2022
ehsannas
approved these changes
Dec 21, 2022
MarkDuckworth
added
the
automerge
Contributor
|
Your PR doesn't have any required checks. Please add required checks to your markduckworth/or-queries branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. |
ehsannas
removed
the
automerge
Contributor
Author
|
Waiting on backend support. Tests pass against the emulator. |
Contributor
|
We probably don't want to auto-merge this? (the CI may have special privileges to prod) |
…js-firestore into markduckworth/or-queries-public
…rkduckworth/or-queries
product-auto-label
Bot
added
size: xl
ehsannas
approved these changes
Feb 17, 2023
ehsannas
pushed a commit
that referenced
this pull request
Mar 6, 2023
* WIP: OR Query with unit tests. No OR operator. * Updating documentation and member visibility. * Formatting * Skipping OR Query system test. * Updated copyright holder for new files. * PR fixes. * feat: OR Query support (#1801) * OR operator support and integration tests. * Updating documentation and member visibility. * Remove usage of OPERATOR_UNSPECIFIED standing in for OR. * Removing private and internal tags from OR query public API members. * Ensure that new OR Query features are in firestore.d.ts and are exported from the main entry point. * Update documentation for OR query features to match android PR 4274. * Removing CompositeFilter and UnaryFilter from the type definitions and JS doc. * Corrected the descending order test for OR queries. * fix: update generated proto types; fix the update script (#1825) * Adding OR enum value for composit filter operator. --------- Co-authored-by: Alexander Fenster <[email protected]> * Updating header copyright to 2023 * Tests that require an index are configured to only run against the emulator. * Test cleanup based on PR comments. --------- Co-authored-by: Alexander Fenster <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: OR Query support