Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

build(node): Remove npm_publish_token from the list of SECRET_MANAGER_KEYS#1752

Merged
bcoe merged 1 commit intomainfrom
markduckworth/fix-publish-task
Aug 2, 2022
Merged

build(node): Remove npm_publish_token from the list of SECRET_MANAGER_KEYS#1752
bcoe merged 1 commit intomainfrom
markduckworth/fix-publish-task

Conversation

@MarkDuckworth
Copy link
Copy Markdown
Contributor

This key has been moved back to keystore.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…_KEYS. This has been moved back to keystore.
@MarkDuckworth MarkDuckworth requested review from a team August 2, 2022 17:26
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Aug 2, 2022
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool

@bcoe bcoe merged commit a67a124 into main Aug 2, 2022
@bcoe bcoe deleted the markduckworth/fix-publish-task branch August 2, 2022 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants