Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: update client libraries to support Database operations #1676

Merged
schmidt-sebastian merged 9 commits into from
Feb 7, 2022
Merged

feat: update client libraries to support Database operations #1676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5037d6e
build: manual update admin with latest protos
summer-ji-eng Feb 2, 2022
65e07d5
rename admin_v1.json
summer-ji-eng Feb 2, 2022
34b0a77
update the generated code
summer-ji-eng Feb 3, 2022
e549740
revert v1beta1 change
summer-ji-eng Feb 4, 2022
41f582f
add new line
summer-ji-eng Feb 4, 2022
284fb72
add headers
summer-ji-eng Feb 4, 2022
238f2dd
update v1 and v1beta1
summer-ji-eng Feb 4, 2022
87d3ae8
merge main
summer-ji-eng Feb 4, 2022
c65f59f
🦉 Updates from OwlBot
gcf-owl-bot[bot] Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,282 changes: 2,282 additions & 0 deletions dev/protos/admin_v1.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dev/protos/firestore_admin_v1_proto_api.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Copyright 2021 Google LLC
* Copyright 2022 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion dev/protos/firestore_admin_v1_proto_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Copyright 2021 Google LLC
* Copyright 2022 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion dev/protos/firestore_v1_proto_api.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Copyright 2021 Google LLC
* Copyright 2022 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion dev/protos/firestore_v1_proto_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Copyright 2021 Google LLC
* Copyright 2022 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion dev/protos/firestore_v1beta1_proto_api.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Copyright 2021 Google LLC
* Copyright 2022 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion dev/protos/firestore_v1beta1_proto_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Copyright 2021 Google LLC
* Copyright 2022 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion dev/src/v1/firestore_admin_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
import {Transform} from 'stream';
import {RequestType} from 'google-gax/build/src/apitypes';
import * as protos from '../../protos/firestore_admin_v1_proto_api';
import jsonProtos = require('../../protos/v1_admin.json');
import jsonProtos = require('../../protos/admin_v1.json');
/**
* Client JSON configuration object, loaded from
* `src/v1/firestore_admin_client_config.json`.
Expand Down
4 changes: 2 additions & 2 deletions dev/src/v1/firestore_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,7 +1226,7 @@ export class FirestoreClient {
*/
write(options?: CallOptions): gax.CancellableStream {
this.initialize();
return this.innerApiCalls.write({}, options);
return this.innerApiCalls.write(null, options);
}

/**
Expand All @@ -1246,7 +1246,7 @@ export class FirestoreClient {
*/
listen(options?: CallOptions): gax.CancellableStream {
this.initialize();
return this.innerApiCalls.listen({}, options);
return this.innerApiCalls.listen(null, options);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions dev/src/v1beta1/firestore_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,7 @@ export class FirestoreClient {
*/
write(options?: CallOptions): gax.CancellableStream {
this.initialize();
return this.innerApiCalls.write({}, options);
return this.innerApiCalls.write(null, options);
}

/**
Expand All @@ -1263,7 +1263,7 @@ export class FirestoreClient {
*/
listen(options?: CallOptions): gax.CancellableStream {
this.initialize();
return this.innerApiCalls.listen({}, options);
return this.innerApiCalls.listen(null, options);
}

/**
Expand Down
16 changes: 4 additions & 12 deletions dev/test/gapic_firestore_v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,9 +1321,7 @@ describe('v1.FirestoreClient', () => {
const response = await promise;
assert.deepStrictEqual(response, expectedResponse);
assert(
(client.innerApiCalls.write as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.write as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down Expand Up @@ -1364,9 +1362,7 @@ describe('v1.FirestoreClient', () => {
});
await assert.rejects(promise, expectedError);
assert(
(client.innerApiCalls.write as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.write as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down Expand Up @@ -1407,9 +1403,7 @@ describe('v1.FirestoreClient', () => {
const response = await promise;
assert.deepStrictEqual(response, expectedResponse);
assert(
(client.innerApiCalls.listen as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.listen as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down Expand Up @@ -1450,9 +1444,7 @@ describe('v1.FirestoreClient', () => {
});
await assert.rejects(promise, expectedError);
assert(
(client.innerApiCalls.listen as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.listen as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down
16 changes: 4 additions & 12 deletions dev/test/gapic_firestore_v1beta1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,9 +1325,7 @@ describe('v1beta1.FirestoreClient', () => {
const response = await promise;
assert.deepStrictEqual(response, expectedResponse);
assert(
(client.innerApiCalls.write as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.write as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down Expand Up @@ -1368,9 +1366,7 @@ describe('v1beta1.FirestoreClient', () => {
});
await assert.rejects(promise, expectedError);
assert(
(client.innerApiCalls.write as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.write as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down Expand Up @@ -1411,9 +1407,7 @@ describe('v1beta1.FirestoreClient', () => {
const response = await promise;
assert.deepStrictEqual(response, expectedResponse);
assert(
(client.innerApiCalls.listen as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.listen as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down Expand Up @@ -1454,9 +1448,7 @@ describe('v1beta1.FirestoreClient', () => {
});
await assert.rejects(promise, expectedError);
assert(
(client.innerApiCalls.listen as SinonStub)
.getCall(0)
.calledWithExactly({}, undefined)
(client.innerApiCalls.listen as SinonStub).getCall(0).calledWith(null)
);
assert.deepStrictEqual(
((stream as unknown as PassThrough)._transform as SinonStub).getCall(0)
Expand Down
1 change: 1 addition & 0 deletions owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@
os.chdir("protos")
os.unlink('protos.js')
os.unlink('protos.d.ts')
os.unlink('protos.json')
Comment thread
summer-ji-eng marked this conversation as resolved.
subprocess.run('./update.sh', shell=True)
os.chdir("../../")

Expand Down
Loading