This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix: create new batch for writes to the same doc#1352
Merged
thebrianchen merged 2 commits intomasterfrom Nov 3, 2020
Merged
Conversation
product-auto-label
Bot
added
the
api: firestore
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 32 32
Lines 19274 19290 +16
Branches 1386 1387 +1
=======================================
+ Hits 18995 19011 +16
Misses 276 276
Partials 3 3
Continue to review full report at Codecov.
|
schmidt-sebastian
approved these changes
Nov 3, 2020
| expect(deleteResult.writeTime).to.deep.equal(new Timestamp(0, 0)); | ||
| }); | ||
|
|
||
| it('has can write to the same document twice', async () => { |
Contributor
There was a problem hiding this comment.
Hm, my amazing Meme doesn't seem to show up, but please drop "has".
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Apr 7, 2022
Co-authored-by: Benjamin E. Coe <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> Source-Link: googleapis/synthtool@e1557e4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:c2641f0628c1077d504eca6b065517b0cc54336f09a9a38e3614c4b412dd9d37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing BulkWriter to add new writes to the same document into a new batch, since the BE endpoint validates that there are no duplicate docs in each batch.
(BulkCommitBatch refactoring coming next)