This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix: fix flaky BulkWriter rate limiter test#1307
Merged
thebrianchen merged 3 commits intomasterfrom Sep 25, 2020
Merged
Conversation
google-cla
Bot
added
the
cla: yes
thebrianchen
force-pushed
the
bc/bulk-flake
branch
from
6524845 to
bd70bfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1307 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 30 30
Lines 18754 18760 +6
Branches 1450 1451 +1
=======================================
+ Hits 18475 18481 +6
Misses 276 276
Partials 3 3
Continue to review full report at Codecov.
|
product-auto-label
Bot
added
the
api: firestore
thebrianchen
force-pushed
the
bc/bulk-flake
branch
from
bd70bfb to
9849aa5
Compare
Author
|
Update: also added an additional check in the BulkWriter constructor to lower the max batch size to match the starting rate if the starting rate is lower than the max batch size. |
schmidt-sebastian
approved these changes
Sep 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test flakes when the CI slows down, which allows enough time to pass such that the test's writes can be made without exceeding the rate limit. To fix this, I created a mock rate limiter that always rejects any request, which makes this test timing-agnostic.