Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

Tracing Flaky test #2244

Closed
#2245
Closed
Tracing Flaky test#2244
#2245
Assignees
ehsannas
Labels
api: firestoreIssues related to the googleapis/nodejs-firestore API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@ehsannas

Description

@ehsannas
ehsannas
opened on Dec 3, 2024

This client-side tracing test

nodejs-firestore/dev/system-test/tracing.ts

Lines 814 to 824 in 1ddb62e

it('document reference update()', async () => {
await runFirestoreOperationInRootSpan(() =>
firestore.collection('foo').doc('bar').update('foo', 'bar2')
);
await waitForCompletedSpans(3);
expectSpanHierarchy(
SPAN_NAME_TEST_ROOT,
SPAN_NAME_DOC_REF_UPDATE,
SPAN_NAME_BATCH_COMMIT
);
});

assumes that the foo/bar document exists -- which it shouldn't. It sometimes passes because most often the previous test creates that document:

nodejs-firestore/dev/system-test/tracing.ts

Lines 802 to 805 in 1ddb62e

it('document reference set()', async () => {
await runFirestoreOperationInRootSpan(() =>
firestore.collection('foo').doc('bar').set({foo: 'bar'})
);

I'll fix this test.

Metadata

Metadata

Assignees

Labels

api: firestoreIssues related to the googleapis/nodejs-firestore API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions