Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-firestore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bd5acf5
Choose a base ref
...
head repository: googleapis/nodejs-firestore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5eea279
Choose a head ref
  • 10 commits
  • 18 files changed
  • 9 contributors

Commits on Aug 1, 2022

  1. build(node): switch back to keystore for publication. (#1750)

    @MarkDuckworth
    MarkDuckworth authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    2aa15b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. build(node): Remove npm_publish_token from the list of SECRET_MANAGER… 

    …_KEYS. This has been moved back to keystore. (#1752)
    @MarkDuckworth
    MarkDuckworth authored Aug 2, 2022
    Configuration menu
    Copy the full SHA
    a67a124 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. fix: Don't allow serialization of firestore settings (#1742) 

    * Dont allow serialization of firestore settings

When logging any firestore object like WriteBatch,Transaction,etc the settings object also gets logged / exposed
This can be seen by running JSON.stringify on any firestore object even a document reference
Many developers log firestore objects to help them debug testing/prod issues, this leaking of entire firestore key via this._settings is a bad practice as per me
We can also use Object.defineProperty to make it non-enumerable or any other technique that you like

* Fix formatting.

* Only redact credentials.

Co-authored-by: Ehsan Nasiri <[email protected]>
    @abhishekwebcode @ehsannas
    abhishekwebcode and ehsannas authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    fa0ad66 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. chore: remove unused proto imports (#1755) 

    - [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468735472

Source-Link: googleapis/googleapis@cfa1b37

Source-Link: googleapis/googleapis-gen@09b7666
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9
    @gcf-owl-bot
    gcf-owl-bot[bot] authored Aug 19, 2022
    Configuration menu
    Copy the full SHA
    fd7002d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. fix: better support for fallback mode (#1756) 

    - [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
    @gcf-owl-bot
    gcf-owl-bot[bot] authored Aug 23, 2022
    Configuration menu
    Copy the full SHA
    a029a6e View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. fix: Update GAX (#1758) 

    * Update GAX

* fix: Update GAX
    @tom-andersen
    tom-andersen authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1931415 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. fix: Pin Typescript to prevent new type checking. (#1764)

    @tom-andersen
    tom-andersen authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    dd01b27 View commit details
    Browse the repository at this point in the history

  2. feat: accept google-gax instance as a parameter (#1757) 

    * chore: update count up_to field type in aggregation queries

PiperOrigin-RevId: 469554568

Source-Link: googleapis/googleapis@c17c5a6

Source-Link: googleapis/googleapis-gen@0b6d950
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGI2ZDk1MDA0MGRhYzdiZDQzMTk0MWJlYTYwZGQ5Njk3NzAwMTFiYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: accept google-gax instance as a parameter

Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: googleapis/googleapis-gen@e97a1ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: use _gaxModule when accessing gax for bundling

PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: googleapis/googleapis-gen@f16a1d2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <[email protected]>
    @gcf-owl-bot @alexander-fenster
    3 people authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    ef59a22 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. fix: Version 7 of protobufjs broke the update.sh script. Added path t… 

    …o built in protobuf. (#1766)
    @tom-andersen
    tom-andersen authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    40f1db3 View commit details
    Browse the repository at this point in the history

  2. chore(main): release 6.1.0 (#1753) 

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    @release-please
    release-please[bot] authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5eea279 View commit details
    Browse the repository at this point in the history
Loading