fix: ReadOnly transaction do not need to commit not rollback. (#2007)

tom-andersen · web-flow · commit 6a220a6f6563 · 2024-03-06T14:12:30.000-05:00
diff --git a/dev/src/transaction.ts b/dev/src/transaction.ts
@@ -509,7 +509,7 @@ export class Transaction implements firestore.Transaction {
    * @internal
    */
   async rollback(): Promise<void> {
-    if (!this._transactionId) {
+    if (!this._transactionId || this._readOnly) {
       return;
     }
 
@@ -605,7 +605,7 @@ export class Transaction implements firestore.Transaction {
         );
       }
       const result = await promise;
-      if (!this._readTime) {
+      if (!this._readOnly) {
         await this.commit();
       }
       return result;
diff --git a/dev/test/transaction.ts b/dev/test/transaction.ts
@@ -780,8 +780,7 @@ describe('transaction operations', () => {
         async (transaction, docRef) => {
           transaction.set(docRef, {foo: 'bar'});
         },
-        begin({readOnly: {}}),
-        rollback()
+        begin({readOnly: {}})
       )
     ).to.eventually.be.rejectedWith(
       'Firestore read-only transactions cannot execute writes.'
@@ -824,8 +823,7 @@ describe('transaction operations', () => {
       {readOnly: true},
       (transaction, docRef) => transaction.get(docRef),
       begin({readOnly: {}}),
-      getDocument(),
-      commit()
+      getDocument()
     );
   });
 

Original file line number	Diff line number	Diff line change
`@@ -509,7 +509,7 @@ export class Transaction implements firestore.Transaction {`
`509`	`509`	`* @internal`
`510`	`510`	`*/`
`511`	`511`	`async rollback(): Promise<void> {`
`512`		`- if (!this._transactionId) {`
	`512`	`+ if (!this._transactionId \|\| this._readOnly) {`
`513`	`513`	`return;`
`514`	`514`	`}`
`515`	`515`
`@@ -605,7 +605,7 @@ export class Transaction implements firestore.Transaction {`
`605`	`605`	`);`
`606`	`606`	`}`
`607`	`607`	`const result = await promise;`
`608`		`- if (!this._readTime) {`
	`608`	`+ if (!this._readOnly) {`
`609`	`609`	`await this.commit();`
`610`	`610`	`}`
`611`	`611`	`return result;`