fix: Remove incorrect,unreachable and unused code (#1983)

abhishekwebcode · milaGGL · web-flow · commit 133f4da892b4 · 2024-01-22T14:23:41.000-05:00
* Prevent Serialization of firestore

The toJSON function spelling name is incorrect therefore this method is not triggered when using JSON.stringify on firestore objects

* Remove unused code

This code is never invoked, the spelling of toJSON is also wrong (  it is toJson here) 
Also the Firestore Class toJSON method works well now for protecting the private keys of firestore instance

---------

Co-authored-by: Mila &lt;107142260+milaGGL@users.noreply.github.com&gt;
diff --git a/dev/src/index.ts b/dev/src/index.ts
@@ -745,13 +745,6 @@ export class Firestore implements firestore.Firestore {
     }
 
     this._settings = settings;
-    this._settings.toJson = function () {
-      const temp = Object.assign({}, this);
-      if (temp.credentials) {
-        temp.credentials = {private_key: '***', client_email: '***'};
-      }
-      return temp;
-    };
     this._serializer = new Serializer(this);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -745,13 +745,6 @@ export class Firestore implements firestore.Firestore {`
`745`	`745`	`}`
`746`	`746`
`747`	`747`	`this._settings = settings;`
`748`		`- this._settings.toJson = function () {`
`749`		`- const temp = Object.assign({}, this);`
`750`		`- if (temp.credentials) {`
`751`		`- temp.credentials = {private_key: '*', client_email: '*'};`
`752`		`- }`
`753`		`- return temp;`
`754`		`- };`
`755`	`748`	`this._serializer = new Serializer(this);`
`756`	`749`	`}`
`757`	`750`