Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@losalex anything additional needed from me to get the tests going and eventual merge/release? I think because I'm first time I might need someone to kick those off for me

@losalex anything additional needed from me to get the tests going and eventual merge/release? I think because I'm first time I might need someone to kick those off for me

Thanks @comp615 for making this change! Added a comment - basically you need to add additional config parameter controlling this feature and add all relevant tests to make sure that this flag by default does not impacts existing code and also does not introduces new failures. Also - did you run this change locally and tested E2E with GCP?

LGTM - please run this change in GCP E2E with getShouldReportErrorsToAPI on/off to make sure it works as expected

We've been running this E2E since last week and have not observed any new errors on either side of the boolean. That value is off/false in our test/development environments and on in our production environments.

Try that new build. I'm really struggling to get the last few error-reporting tests running locally, so kind of guessing at what the tests need if anything. Would be much easier to debug in CI :-/