fix: in Koa2 interface await next as a function#336
fix: in Koa2 interface await next as a function#336DominicKramer merged 2 commits intogoogleapis:masterfrom
next as a function#336Conversation
googlebot
added
the
cla: yes
This change introduces a Koa2 plugin that is available through the `koa2` property. The existing Koa1 plugin is still accessed through the `koa` property. Fixes: #8
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
======================================
Coverage 96.1% 96.1%
======================================
Files 34 34
Lines 1694 1694
Branches 76 76
======================================
Hits 1628 1628
Misses 49 49
Partials 17 17Continue to review full report at Codecov.
|
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
Can we also a test that exercises this code?
|
@ofrobots I'm in the process of creating the tests, and I think they should be samples tests. In particular, I am updating the samples to include samples for the different frameworks. Then I'll update the samples tests to test each sample. |
|
Since the sample test changes involve a bit of work, I made an issue (#337) to track it. A follow-up PR will implement that work, and thus I will land this PR. That way, each PR can focus on a specific task. |
|
Repeating my comment on the issue, this fixed the |
PR googleapis#336 fixed the Koa plugin, but didn't fix the Koa2 plugin. Fixes: googleapis#335
5 participants
Fixes: #335