Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

chore: test Restify 8 in the install tests#324

Merged
DominicKramer merged 2 commits intogoogleapis:masterfrom
DominicKramer:chore/add-restify-18-tests
Mar 14, 2019
Merged

chore: test Restify 8 in the install tests#324
DominicKramer merged 2 commits intogoogleapis:masterfrom
DominicKramer:chore/add-restify-18-tests

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

Fixes #319

@DominicKramer DominicKramer requested a review from a team March 10, 2019 19:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2019
@DominicKramer DominicKramer changed the title chore: test Restify 18 in the install tests chore: test Restify 8 in the install tests Mar 10, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2019

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #324   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files          34      34           
  Lines        1695    1695           
  Branches       76      76           
======================================
  Hits         1629    1629           
  Misses         49      49           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f7d76...41356cf. Read the comment docs.

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@DominicKramer is this ready to go?

@DominicKramer DominicKramer merged commit c976ba4 into googleapis:master Mar 14, 2019
@DominicKramer
Copy link
Copy Markdown
Contributor Author

I was just waiting for the tests to re-run after doing a rebase. I've merged it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants