Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

chore(deps): update dependency restify to v8#318

Merged
DominicKramer merged 1 commit intomasterfrom
renovate/restify-8.x
Mar 1, 2019
Merged

chore(deps): update dependency restify to v8#318
DominicKramer merged 1 commit intomasterfrom
renovate/restify-8.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Feb 21, 2019

This PR contains the following updates:

Package Type Update Change References
restify devDependencies major ^7.2.0 -> ^8.0.0 homepage, source

Release Notes

restify/node-restify

v8.0.0

Compare Source

Breaking Changes
  • Dropped Support for Node v4.x and Node v6.x

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@DominicKramer
Copy link
Copy Markdown
Contributor

It looks like supporting Restify 8 won't require changes to the plugins because the breaking change from 7 to 8 was dropping support for Node 4.x and 6.x (https://github.com/restify/node-restify/blob/master/CHANGELOG.md).

However, we should still have post-install tests for Restify 8.

@ofrobots
Copy link
Copy Markdown
Contributor

@DominicKramer does that means this PR can go ahead, or is there work needed before the PR goes ahead?

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 28, 2019
@DominicKramer
Copy link
Copy Markdown
Contributor

Yes, the PR can land. It should not break customers.

@ofrobots ofrobots added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2019

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #318   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files          34      34           
  Lines        1695    1695           
  Branches       76      76           
======================================
  Hits         1629    1629           
  Misses         49      49           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ae647...37c9ffa. Read the comment docs.

@DominicKramer
Copy link
Copy Markdown
Contributor

Supporting Restify 8 is being tracked at issue #319.

@DominicKramer DominicKramer merged commit f3399b4 into master Mar 1, 2019
@renovate renovate Bot deleted the renovate/restify-8.x branch March 1, 2019 00:36
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants