This repository was archived by the owner on Mar 5, 2026. It is now read-only.
refactor: cleanup types for reportManualError#310
Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom Feb 11, 2019
Merged
refactor: cleanup types for reportManualError#310JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
|
|
||
| import * as http from 'http'; | ||
| import * as is from 'is'; | ||
| import {any} from 'joi'; |
Contributor
Author
There was a problem hiding this comment.
shakes fist VSCode!
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 34 34
Lines 1687 1687
Branches 76 76
=======================================
Hits 1621 1621
Misses 49 49
Partials 17 17
Continue to review full report at Codecov.
|
Contributor
|
I could go either way with the semver major-ness. Do you think there are going to be other changes you want to bundle? |
JustinBeckwith
approved these changes
Feb 11, 2019
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
LGTM w/ nit - your call on the semverness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #35
I'm debating if this is semver major for typescript users.