This repository was archived by the owner on Mar 5, 2026. It is now read-only.
chore: change sort order for retrieving err items#289
Merged
DominicKramer merged 8 commits intogoogleapis:masterfrom Dec 19, 2018
Merged
Conversation
This is being done to address the system test flakiness by having the most recently created error item listed first in the list of error items retrieved from the error reporting service.
googlebot
added
the
cla: yes
ofrobots
reviewed
Dec 13, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
Is this code utilized on non-test paths? It is not in the test/ so my gut feel is yes. Is this a user-visible change?
Contributor
Author
|
This isn't a user visible change. The |
ofrobots
approved these changes
Dec 13, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM. Would it make sense to move this code to the test directory?
DominicKramer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
DominicKramer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is being done to address the system test flakiness by having
the most recently created error item listed first in the list
of error items retrieved from the error reporting service.