This repository was archived by the owner on Mar 5, 2026. It is now read-only.
chore: address system test flakiness#275
Merged
DominicKramer merged 12 commits intogoogleapis:masterfrom Dec 6, 2018
Merged
Conversation
It looks like the underlying issue with the system tests is that it may take longer than the test timeout before the API reports an error. I have increased the timeout to 10 minutes since the code will now poll the server so that it can quit early if a response comes back earlier than the timeout.
googlebot
added
the
cla: yes
DominicKramer
changed the title
kjin
approved these changes
Dec 6, 2018
…ramer/nodejs-error-reporting into chore/increase-sys-test-timeout
…ramer/nodejs-error-reporting into chore/increase-sys-test-timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.