Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

Update region tags in samples#259

Merged
ofrobots merged 2 commits intomasterfrom
regionTags
Nov 21, 2018
Merged

Update region tags in samples#259
ofrobots merged 2 commits intomasterfrom
regionTags

Conversation

@fhinkel
Copy link
Copy Markdown
Contributor

@fhinkel fhinkel commented Nov 16, 2018

Updating the region tags to match our samples tracker.

I'll send a second PR removing the old tags once the docs got re-published.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2018
@fhinkel fhinkel mentioned this pull request Nov 16, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2018

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          29       29           
  Lines        1241     1241           
  Branches      151      151           
=======================================
  Hits         1098     1098           
  Misses         87       87           
  Partials       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120b2fa...6533ada. Read the comment docs.

@fhinkel
Copy link
Copy Markdown
Contributor Author

fhinkel commented Nov 21, 2018

Anybody willing to force merge this? Only changes are to region tags, not affecting system tests.

@ofrobots ofrobots merged commit caf8bfb into master Nov 21, 2018
@ofrobots ofrobots deleted the regionTags branch November 21, 2018 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants