fix: sys tests use async/await to allow a fix#253
fix: sys tests use async/await to allow a fix#253JustinBeckwith merged 7 commits intogoogleapis:masterfrom
Conversation
The system tests have been updated to use async/await. This is done to make it easier to see errors in the tests and fix them. Fixes: googleapis#213
googlebot
added
the
cla: yes
|
@DominicKramer it looks like the unit tests are failing - i was going to wait until those were passing to review :) |
|
@JustinBeckwith Yes I'm still in the process of resolving some issues that are causing the tests to fail. Normally, I don't expect a review until I've explicitly added reviewers. However, I could instead indicate in the title not to review. What approach do you suggest I should follow that would align with your team's expectations for a PR that doesn't need to be reviewed yet? |
|
Ahhhh, got it. Apologies! Typically I don't open the PR until it's ready for some kind of review 🤷♂️ This is my bad though, I should have paid better attention. I just saw the issue where someone was asking for a release and got eager :) |
…amer/nodejs-error-reporting into fix/async-and-fix-system-tests
The API documents the count as only being approximate and its value is not accurate enough to use in the tests. When the tests were running I watched the error reporting console and saw the count be (inccorectly) 2 for a few seconds before dropping down to the correct value of 1.
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=========================================
Coverage ? 88.47%
=========================================
Files ? 29
Lines ? 1241
Branches ? 151
=========================================
Hits ? 1098
Misses ? 87
Partials ? 56Continue to review full report at Codecov.
|
|
@JustinBeckwith No worries. It is ready to review now :) |
|
|
||
| cb(matchedErrors); | ||
| async function verifyAllGroups( | ||
| messageTest: (message: string) => void, maxCount: number, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
3 participants
The system tests have been updated to use async/await. This is
done to make it easier to see errors in the tests and fix them.
Fixes: #213