This repository was archived by the owner on Mar 5, 2026. It is now read-only.
refactor: remove unused deps and simplify#248
Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom Nov 9, 2018
JustinBeckwith:less
Merged
refactor: remove unused deps and simplify#248JustinBeckwith merged 2 commits intogoogleapis:masterfrom JustinBeckwith:less
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith:less
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 88.79% 88.47% -0.32%
==========================================
Files 29 29
Lines 1276 1241 -35
Branches 151 151
==========================================
- Hits 1133 1098 -35
Misses 87 87
Partials 56 56
Continue to review full report at Codecov.
|
jkwlui
reviewed
Nov 9, 2018
| client.sendError(em); | ||
| } | ||
| if (is.object(client) && is.function(client.sendError)) | ||
| { client.sendError(em); } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| client.sendError(hapiErrorHandler(err, req, config)); | ||
| }); | ||
| } | ||
| if (is.function(server.on)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jkwlui
approved these changes
Nov 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a few things:
Object.assignis