This repository was archived by the owner on Mar 5, 2026. It is now read-only.
chore: update nock path in system tests#216
Merged
DominicKramer merged 4 commits intogoogleapis:masterfrom Oct 22, 2018
Merged
Conversation
googlebot
added
the
cla: yes
ghost
assigned
ofrobots
approved these changes
Sep 25, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM. Do you want to push this as a branch so that the system tests get exercised?
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 29 29
Lines 1276 1276
Branches 151 151
=======================================
Hits 1133 1133
Misses 87 87
Partials 56 56
Continue to review full report at Codecov.
|
jkwlui
force-pushed
the
chore/update-nock-in-system-tests
branch
from
eaf6f23 to
de58222
Compare
DominicKramer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
|
@kinwa91 this is still needing a little love |
DominicKramer
force-pushed
the
chore/update-nock-in-system-tests
branch
from
c8acddf to
62074e1
Compare
DominicKramer
force-pushed
the
chore/update-nock-in-system-tests
branch
2 times, most recently
from
eec4048 to
a2de43e
Compare
commit 2679b06 Author: Jonathan Lui <[email protected]> Date: Tue Sep 25 14:21:51 2018 -0700 use kokoros stored system key commit 3ead9c1 Merge: b761863 4aba4cd Author: Justin Beckwith <[email protected]> Date: Tue Sep 25 14:10:23 2018 -0700 Merge branch 'master' into autosynth commit b761863 Author: Jonathan Lui <[email protected]> Date: Tue Sep 25 14:06:11 2018 -0700 prevent credential from leaking commit 29e034c Author: Jonathan Lui <[email protected]> Date: Tue Sep 25 13:56:53 2018 -0700 add GCLOUD_TESTS_API_KEY before system test commit d5efc07 Author: Jonathan Lui <[email protected]> Date: Tue Sep 25 13:54:39 2018 -0700 add repo-specific system-test env vars to kokoro pre hook commit 25e3347 Author: dpebot <[email protected]> Date: Fri Sep 21 14:34:37 2018 -0700 Re-generate library using /synth.py
The package appears to be broken and is not needed anyway.
DominicKramer
force-pushed
the
chore/update-nock-in-system-tests
branch
from
acac9fb to
a364940
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated path and the following environment variables
are needed for the systems tests to pass.