This repository was archived by the owner on Mar 5, 2026. It is now read-only.
chore: fix sys test failure caused by a type error#188
Merged
DominicKramer merged 2 commits intogoogleapis:masterfrom Aug 6, 2018
Merged
chore: fix sys test failure caused by a type error#188DominicKramer merged 2 commits intogoogleapis:masterfrom
DominicKramer merged 2 commits intogoogleapis:masterfrom
Conversation
ghost
assigned
googlebot
added
the
cla: yes
Contributor
|
Can you include a link to the failure job? |
Contributor
Author
|
@ofrobots I've included a link to the failed job. |
ofrobots
approved these changes
Aug 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failed tests can be viewed at https://circleci.com/gh/googleapis/nodejs-error-reporting/4582?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.
In particular, the
countproperty on a error is of typestringbut was compared against a number.