This repository was archived by the owner on Mar 5, 2026. It is now read-only.
chore: do not target es5#187
Merged
DominicKramer merged 1 commit intogoogleapis:masterfrom Aug 2, 2018
Merged
Conversation
Targeting `es5` caused the koa plugin, which is a generator function, to be transpiled into a regular function. As a result, Koa@1 would refuse to use the plugin.
googlebot
added
the
cla: yes
ghost
assigned
kjin
approved these changes
Aug 2, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeting
es5caused the koa plugin, which is a generatorfunction, to be transpiled into a regular function. As a result,
Koa@1 would refuse to use the plugin.