Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

fix: fix installation tests#183

Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
DominicKramer:fix/fix-install-tests-console-log-level
Jul 31, 2018
Merged

fix: fix installation tests#183
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
DominicKramer:fix/fix-install-tests-console-log-level

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

The inclusion of console-log-level broke the installation tests
by requiring TypeScript users of the error reporting library to
install @types/console-log-level to compile their code.

The inclusion of `console-log-level` broke the installation tests
by requiring TypeScript users of the error reporting library to
install `@types/console-log-level` to compile their code.
@DominicKramer DominicKramer requested a review from a team July 31, 2018 16:42
@ghost ghost assigned DominicKramer Jul 31, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2018
Copy link
Copy Markdown
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

@JustinBeckwith JustinBeckwith merged commit 40a4386 into googleapis:master Jul 31, 2018
This was referenced Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants