Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

CLA signed.

CLAs look good, thanks!

Awesome. Thanks for contributing this. I think it looks good, but I need to think more about whether there should be separate koa and koa2 properties. For hapi, the hapi property works for both hapi6 and hapi7. I'm not sure if it possible to do this with koa.

@DominicKramer that’s fair, and it should be possible to support both by doing an argument count. I can go ahead and update this, but I’m also curious, do you know why the koa1 tests aren’t failing right now?

Thank you for looking into how to support Koa 1 and 2 together. It looks like there isn't a koa interface unit test. This is something that I will need to create.

Hey @DominicKramer - I changed this to work with both koa1 and koa2. I did escape the type system a bit with some any casts, which probably isn't ideal. Feel free to add better typing, or perhaps I'll have time to look at that soon.

@mike-marcacci Thanks for working on this. It looks really good. I will take care of updating the types for you. Thanks.

Awesome! Thanks so much @DominicKramer. I did also want to reiterate my note from the original PR: I'm pretty sure the "system-tests" aren't actually being run, at least locally with npm test. You might want to confirm this before merging incoming PRs in general :)

@mike-marcacci Sorry, I missed your "system tests" comment. It is expected that the system tests are not run with npm test. The system tests and samples tests are run separately using the npm run system-test and npm run samples-test commands and are handled by CircleCI. Thank you, though, for asking about this.

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

CLAs look good, thanks!

🤦🏻‍♂️ I guess I should have read the package.json. Also it looks like I inadvertently pulled in some greenkeeper commits and broke the CLA googlebot, so I rebased and forced-pushed.

No worries.

There were a few issues unrelated to this PR that are blocking this PR from landing. Some are fixed in PR #183 and PR #185. There is another in the pipeline. When those are done, this PR should be unblocked.