Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

koa2 interface not awaiting next middleware #335

Closed
#339
Closed
koa2 interface not awaiting next middleware#335
#339
Assignees
DominicKramer
Labels
🚨This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@codyzu

Description

@codyzu
codyzu
opened on Apr 9, 2019

nodejs-error-reporting/src/interfaces/koa2.ts

Line 57 in 4bd26cd

await next;

next is function in koa. This should be await next(), awaiting the response from the next function (i.e. the next middleware in the stack).

I would go as far to say there must be something missing in the tests this hasn't been noticed before :-(

Environment details

  • OS: linux
  • Node.js version: 10.15.1
  • npm version: 6.4.1
  • @google-cloud/error-reporting version: 0.6.1

Steps to reproduce

  1. Use koa2 interface in middleware stack
  2. Call api and watch 404s get returned....

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions