Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Convert to TypeScript#97

Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith:typescript
Sep 6, 2018
Merged

Convert to TypeScript#97
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith:typescript

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented Sep 6, 2018

BREAKING CHANGE: This module now supports es module style imports. This provides forward compatibility with TypeScript, Babel, and the new es module spec.

Old code

const DNS = require('@google-cloud/dns');
const dns = new DNS();
// OR...
const dns = require('@google-cloud/dns')();

New code

const {DNS} = require('@google-cloud/dns');
const dns = new DNS();

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2018
@ghost ghost assigned JustinBeckwith Sep 6, 2018
@JustinBeckwith JustinBeckwith requested review from a team, alexander-fenster, fhinkel and jkwlui and removed request for alexander-fenster September 6, 2018 03:02
fhinkel
fhinkel approved these changes Sep 6, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp

@JustinBeckwith JustinBeckwith merged commit 3eb3de6 into googleapis:master Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkwlui jkwlui Awaiting requested review from jkwlui

1 more reviewer

@fhinkel fhinkel fhinkel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JustinBeckwith JustinBeckwith

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JustinBeckwith @fhinkel @googlebot