This repository was archived by the owner on Dec 19, 2023. It is now read-only.
chore: use es classes#88
Merged
JustinBeckwith merged 3 commits intogoogleapis:masterfrom Aug 23, 2018
JustinBeckwith:51
Merged
Conversation
JustinBeckwith
added
the
do not merge
googlebot
added
the
cla: yes
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 269 241 -28
=====================================
- Hits 269 241 -28
Continue to review full report at Codecov.
|
Contributor
|
Good question! I guess we never had one of these configured in CI, as wrong as that sounds. I always use my own domain: I'm not sure exactly how to grant permissions to the system tests account, but I followed a lead from the Cloud DNS Troubleshooting page where it said: "you must verify domain ownership". I followed that link, and added "[email protected]" as an owner of "gitnpm.com". |
Contributor
Author
|
@stephenplusplus @kinwa91 this is ready for a look :) |
JustinBeckwith
removed
the
do not merge
theacodes
approved these changes
Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stephenplusplus @callmehiphop I don't know how to run the system tests on this one :( It asks me for a
GCLOUD_TESTS_DNS_DOMAINenv var. Any insight on how to run these?