This repository was archived by the owner on Dec 19, 2023. It is now read-only.
docs: First argument of Zone#create is required#125
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Sep 28, 2018
carnesen:createZone-config-required
Merged
docs: First argument of Zone#create is required#125JustinBeckwith merged 1 commit intogoogleapis:masterfrom carnesen:createZone-config-required
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
carnesen:createZone-config-required
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
I'm going to submit a new PR that fixes both the jsdocs and the types ... |
Contributor
Author
|
Actually, #126 is not as simple as I first thought. I'll just let this stand as is for now, ready to merge on approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jsdocs for DNS#createZone and Zone#create currently indicate that
config/metadataargument is optional. In fact it is required. When this PR is merged, the jsdocs will indicate as much.