This repository was archived by the owner on Dec 19, 2023. It is now read-only.
improvement: Remove "prettier" from "npm run fix"#116
Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom Sep 25, 2018
carnesen:remove-prettier
Merged
improvement: Remove "prettier" from "npm run fix"#116JustinBeckwith merged 2 commits intogoogleapis:masterfrom carnesen:remove-prettier
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
carnesen:remove-prettier
Conversation
Our eslint configuration already reports `prettier` diffs as errors via eslint-plugin-prettier. These diffs are all auto-fixable by eslint. Therefore there's no need to call the `prettier` CLI command.
googlebot
added
the
cla: yes
ghost
assigned
JustinBeckwith
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our eslint configuration already reports "prettier" diffs as errors via eslint-plugin-prettier. These diffs are all auto-fixable by
eslint --fix. Therefore there's no need to call theprettierCLI command.