This repository was archived by the owner on Dec 19, 2023. It is now read-only.
fix: improve the types#114
Merged
JustinBeckwith merged 6 commits intogoogleapis:masterfrom Sep 25, 2018
JustinBeckwith:typeyah
Merged
fix: improve the types#114JustinBeckwith merged 6 commits intogoogleapis:masterfrom JustinBeckwith:typeyah
JustinBeckwith merged 6 commits intogoogleapis:masterfrom
JustinBeckwith:typeyah
Conversation
googlebot
added
the
cla: yes
ghost
assigned
carnesen
reviewed
Sep 24, 2018
| delete(): Promise<DeleteRecordResponse>; | ||
| delete(callback: ChangeCallback): void; | ||
| delete(callback?: ChangeCallback): void|Promise<DeleteRecordResponse> { | ||
| this.zone_.deleteRecords(this, callback!); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * const apiResponse = data[1]; | ||
| * }); | ||
| */ | ||
| import(localPath: string, callback: ChangeCallback) {fs.readFile(localPath, 'utf-8', (err, file) => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jkwlui
reviewed
Sep 24, 2018
| * @param {?Change} change A {@link Change} object. | ||
| * @param {object} apiResponse The full API response. | ||
| */ | ||
| export type DeleteRecordCallback = |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jkwlui
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)