Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

fix(DNS): Add post-promisify type overloads to DNS methods#112

Merged
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
carnesen:promisify-dns-types
Sep 22, 2018
Merged

fix(DNS): Add post-promisify type overloads to DNS methods#112
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
carnesen:promisify-dns-types

Conversation

@carnesen
Copy link
Copy Markdown
Contributor

@carnesen carnesen commented Sep 22, 2018

This PR adds promisified overloads for DNS async methods getZones and createZone.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2018
@carnesen carnesen changed the title fix(DNS): Promisify DNS method signatures fix(DNS): Add post-promisify type overloads to DNS methods Sep 22, 2018
JustinBeckwith
JustinBeckwith approved these changes Sep 22, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JustinBeckwith JustinBeckwith merged commit 176089a into googleapis:master Sep 22, 2018
@carnesen carnesen deleted the promisify-dns-types branch September 22, 2018 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carnesen @JustinBeckwith @googlebot