Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

TypeScript: Zone#create should have required parameter of type CreateZoneRequest #126

@carnesen

Description

@carnesen

Currently the TypeScript type of Zone#create is inherited from ServiceObject#create. Effectively the first argument is optional and if present can have any shape. (TypeScript doesn't do the excess property check on assignments to an empty object type.) That doesn't jibe with either the docs or the runtime checks. Instead, the first parameter of Zone#create should be required of type CreateZoneRequest. (Maybe without the "name" property?).

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: dnsIssues related to the googleapis/nodejs-dns API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions