This repository was archived by the owner on Sep 27, 2023. It is now read-only.
chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport#785
Merged
gcf-merge-on-green[bot] merged 6 commits intomainfrom Jan 5, 2023
Conversation
…ded as a LocationCategory value PiperOrigin-RevId: 487581128 Source-Link: googleapis/googleapis@9140e55 Source-Link: https://github.com/googleapis/googleapis-gen/commit/502b50e61710bca3d774cb918314cb1ef39e6fe9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTAyYjUwZTYxNzEwYmNhM2Q3NzRjYjkxODMxNGNiMWVmMzllNmZlOSJ9
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java) PiperOrigin-RevId: 493113566 Source-Link: googleapis/googleapis@758f0d1 Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
sofisl
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566
Source-Link: googleapis/googleapis@758f0d1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
BEGIN_NESTED_COMMIT
feat: ExcludeByHotword added as an ExclusionRule type, NEW_ZEALAND added as a LocationCategory value
PiperOrigin-RevId: 487581128
Source-Link: googleapis/googleapis@9140e55
Source-Link: https://github.com/googleapis/googleapis-gen/commit/502b50e61710bca3d774cb918314cb1ef39e6fe9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTAyYjUwZTYxNzEwYmNhM2Q3NzRjYjkxODMxNGNiMWVmMzllNmZlOSJ9
END_NESTED_COMMIT