Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport#785

Merged
gcf-merge-on-green[bot] merged 6 commits intomainfrom
owl-bot-copy
Jan 5, 2023

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Nov 10, 2022

  • Regenerate this pull request now.

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9

BEGIN_NESTED_COMMIT
feat: ExcludeByHotword added as an ExclusionRule type, NEW_ZEALAND added as a LocationCategory value
PiperOrigin-RevId: 487581128

Source-Link: googleapis/googleapis@9140e55

Source-Link: https://github.com/googleapis/googleapis-gen/commit/502b50e61710bca3d774cb918314cb1ef39e6fe9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTAyYjUwZTYxNzEwYmNhM2Q3NzRjYjkxODMxNGNiMWVmMzllNmZlOSJ9
END_NESTED_COMMIT

…ded as a LocationCategory value

PiperOrigin-RevId: 487581128

Source-Link: googleapis/googleapis@9140e55

Source-Link: https://github.com/googleapis/googleapis-gen/commit/502b50e61710bca3d774cb918314cb1ef39e6fe9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTAyYjUwZTYxNzEwYmNhM2Q3NzRjYjkxODMxNGNiMWVmMzllNmZlOSJ9
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team November 10, 2022 20:50
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Nov 10, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 10, 2022
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Nov 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 10, 2022
@product-auto-label product-auto-label Bot added the api: dlp Issues related to the googleapis/nodejs-dlp API. label Nov 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 10, 2022
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Nov 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2022
…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport

chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566

Source-Link: googleapis/googleapis@758f0d1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
@gcf-owl-bot gcf-owl-bot Bot changed the title feat: ExcludeByHotword added as an ExclusionRule type, NEW_ZEALAND added as a LocationCategory value chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 5, 2023
@sofisl sofisl added automerge Merge the pull request once unit tests and other checks pass. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 5, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 5, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 5b54b2e into main Jan 5, 2023
@gcf-merge-on-green gcf-merge-on-green Bot deleted the owl-bot-copy branch January 5, 2023 20:46
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: dlp Issues related to the googleapis/nodejs-dlp API. owl-bot-copy size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants