Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

test: fix sample test for listJobs#734

Merged
alexander-fenster merged 4 commits intomainfrom
fix-samples
Aug 19, 2022
Merged

test: fix sample test for listJobs#734
alexander-fenster merged 4 commits intomainfrom
fix-samples

Conversation

@alexander-fenster
Copy link
Copy Markdown
Contributor

This is the proper fix for listJobs test. The listJobs sample requires a job type, and returns an empty list if no job type is given.

@alexander-fenster alexander-fenster requested review from a team and sofisl August 19, 2022 20:48
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: dlp Issues related to the googleapis/nodejs-dlp API. samples Issues that are directly related to samples. labels Aug 19, 2022
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Aug 19, 2022
@alexander-fenster alexander-fenster merged commit 22550d9 into main Aug 19, 2022
@alexander-fenster alexander-fenster deleted the fix-samples branch August 19, 2022 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: dlp Issues related to the googleapis/nodejs-dlp API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants