This repository was archived by the owner on Sep 27, 2023. It is now read-only.
fix(samples-test): increase likelihood threshold#222
Merged
JustinBeckwith merged 1 commit intomasterfrom Jan 25, 2019
Merged
Conversation
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like some kind of backend algo changes that increased the
likelihood result of detecting phone number in the text which causes
it to show up when we set minLikelihood to
LIKELY.THE FIX
Increasing the threshold to
VERY_LIKELYso it won't be returned inthe result to fix the samples test.