This repository was archived by the owner on Feb 20, 2026. It is now read-only.
test: sort results, check for sorted order#1245
Merged
danieljbruce merged 3 commits intogoogleapis:mainfrom Apr 2, 2024
Merged
test: sort results, check for sorted order#1245danieljbruce merged 3 commits intogoogleapis:mainfrom
danieljbruce merged 3 commits intogoogleapis:mainfrom
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: xs
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
bhshkh
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample test for OR queries is flakey. As the sample loops through the entities retrieved it prints out the entities and the test checks the exact string that is printed out. However,
runQuerymight fetch the entities in any order so for this test to consistently work we need to sort the entities it fetches and then compare the printed sorted entities with a string. By sorting the fetched entities it means the test will not fail if the entities are returned in a different order. The test should not expect a specific order for the entities sincerunQuerydoesn't guarantee the entities to be in a specific order.