Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

chore: remove the blob error workaround#1072

Merged
danieljbruce merged 2 commits intogoogleapis:mainfrom
danieljbruce:755-save-empty-buffer-throws-error
Feb 24, 2023
Merged

chore: remove the blob error workaround#1072
danieljbruce merged 2 commits intogoogleapis:mainfrom
danieljbruce:755-save-empty-buffer-throws-error

Conversation

@danieljbruce
Copy link
Copy Markdown
Contributor

@danieljbruce danieljbruce commented Feb 24, 2023

An error with code 3 was thrown when the test code was run before the workaround was added and before the proto changes were made. Now that the proto changes have been made, the workaround is no longer required so it is removed in this commit.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #755 🦕

An error with code 3 was thrown when the test code was run before the workaround was added and before the proto changes were made. Now that the proto changes have been made, the workaround is no longer required so it is removed in this commit.
@danieljbruce danieljbruce requested review from a team February 24, 2023 16:28
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Feb 24, 2023
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Feb 24, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Feb 24, 2023
Change a test so that it matches what it originally was back in 2020.
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@danieljbruce danieljbruce merged commit 6ce2e5b into googleapis:main Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/nodejs-datastore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving an empty Buffer throws an error.

2 participants