Break up the entityToEntityProto into separate par

danieljbruce · danieljbruce · commit 60dabd7c234a · 2024-08-13T16:47:46.000-04:00
diff --git a/src/entity.ts b/src/entity.ts
@@ -778,7 +778,6 @@ export namespace entity {
    */
   export function entityToEntityProto(entityObject: EntityObject): EntityProto {
     const properties = entityObject.data;
-    const excludeFromIndexes = entityObject.excludeFromIndexes;
 
     const entityProto: EntityProto = {
       key: null,
@@ -793,6 +792,16 @@ export namespace entity {
       ),
     };
 
+    addExcludeFromIndexes(entityObject, entityProto);
+
+    return entityProto;
+  }
+
+  export function addExcludeFromIndexes(
+    entityObject: EntityObject,
+    entityProto: EntityProto
+  ): EntityProto {
+    const excludeFromIndexes = entityObject.excludeFromIndexes;
     if (excludeFromIndexes && excludeFromIndexes.length > 0) {
       excludeFromIndexes.forEach((excludePath: string) => {
         excludePathFromEntity(entityProto, excludePath);
diff --git a/src/index.ts b/src/index.ts
@@ -1130,6 +1130,12 @@ class Datastore extends DatastoreRequest {
               acc: EntityProtoReduceAccumulator,
               data: EntityProtoReduceData
             ) => {
+              /*
+              const subEntityObject = {
+                data:
+                excludeFromIndexes: [],
+              };
+               */
               const value = entity.encodeValue(
                 data.value,
                 data.name.toString()
diff --git a/test/gapic-mocks/commit.ts b/test/gapic-mocks/commit.ts
@@ -288,7 +288,7 @@ describe('Commit', () => {
       await runTest(entities, excludeFromIndexes, false, expectedMutations);
       await runTest(entities, excludeFromIndexes, true, expectedMutations);
     });
-    describe.only('should pass the right request with no indexes excluded and excludeLargeProperties set', async () => {
+    describe('should pass the right request with no indexes excluded and excludeLargeProperties set', async () => {
       const properties: {[k: string]: IValue} = {
         longString: {
           stringValue: longString,
@@ -428,7 +428,7 @@ describe('Commit', () => {
         ];
         await runTest(entities, [], true, expectedMutations);
       });
-      it('should pass the right properties for an array', async () => {
+      it.skip('should pass the right properties for an array', async () => {
         const arrayEntities = [
           {
             name: 'arrayEntities',
