This repository was archived by the owner on Jul 20, 2023. It is now read-only.
Conversation
Changing HTTP bindings and/or their order might be a breaking change for libraries. PiperOrigin-RevId: 430239565 Source-Link: googleapis/googleapis@71fe7ff Source-Link: https://github.com/googleapis/googleapis-gen/commit/1f496cc36dd77921e45a278114bbc2198cc8352a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWY0OTZjYzM2ZGQ3NzkyMWU0NWEyNzgxMTRiYmMyMTk4Y2M4MzUyYSJ9
product-auto-label
Bot
added
the
api: dataflow
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
bcoe
added
the
do not merge
|
we should be hesitant to merge a breaking change. |
Committer: @summer-ji-eng PiperOrigin-RevId: 433031262 Source-Link: googleapis/googleapis@2a55d13 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2fce3893ae9da47763e0872c4a3a87d9ff78771f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZjZTM4OTNhZTlkYTQ3NzYzZTA4NzJjNGEzYTg3ZDlmZjc4NzcxZiJ9
gcf-owl-bot
Bot
changed the title
trusted-contributions-gcf
Bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
removed
the
do not merge
trusted-contributions-gcf
Bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer: @summer-ji-eng
PiperOrigin-RevId: 433031262
Source-Link: googleapis/googleapis@2a55d13
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2fce3893ae9da47763e0872c4a3a87d9ff78771f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZjZTM4OTNhZTlkYTQ3NzYzZTA4NzJjNGEzYTg3ZDlmZjc4NzcxZiJ9
fix!: Use http binding with location field as primary http bindings
Changing HTTP bindings and/or their order might be a breaking change for libraries.
PiperOrigin-RevId: 430239565
Source-Link: googleapis/googleapis@71fe7ff
Source-Link: https://github.com/googleapis/googleapis-gen/commit/1f496cc36dd77921e45a278114bbc2198cc8352a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWY0OTZjYzM2ZGQ3NzkyMWU0NWEyNzgxMTRiYmMyMTk4Y2M4MzUyYSJ9