Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

Commit 41c8fd6

Browse files
feat: Add the ability to plumb environment capabilities through v1beta3 protos. (#53)
* chore: update v2.14.2 gapic-generator-typescript Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: https://github.com/googleapis/googleapis-gen/commit/930b673103e92523f8cfed38decd7d3afae8ebe7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add the ability to plumb environment capabilities through v1beta3 protos. PiperOrigin-RevId: 434899727 Source-Link: googleapis/googleapis@392ae91 Source-Link: https://github.com/googleapis/googleapis-gen/commit/febf173172483fcebd5668dd32f3d7352a4420ce Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmViZjE3MzE3MjQ4M2ZjZWJkNTY2OGRkMzJmM2Q3MzUyYTQ0MjBjZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 6bfb6bd commit 41c8fd6

9 files changed

Lines changed: 54 additions & 12 deletions

protos/google/dataflow/v1beta3/environment.proto

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,6 +415,10 @@ message SdkHarnessContainerImage {
415415
// Environment ID for the Beam runner API proto Environment that corresponds
416416
// to the current SDK Harness.
417417
string environment_id = 3;
418+
419+
// The set of capabilities enumerated in the above Environment proto. See also
420+
// https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/beam_runner_api.proto
421+
repeated string capabilities = 4;
418422
}
419423

420424
// Describes one particular pool of Cloud Dataflow workers to be

protos/protos.d.ts

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/protos.js

Lines changed: 39 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/protos.json

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/gapic_flex_templates_service_v1beta3.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,6 @@ describe('v1beta3.FlexTemplatesServiceClient', () => {
280280
new protos.google.dataflow.v1beta3.LaunchFlexTemplateRequest()
281281
);
282282
request.projectId = '';
283-
const expectedHeaderRequestParams = 'project_id=';
284283
const expectedError = new Error('The client has already been closed.');
285284
client.close();
286285
await assert.rejects(client.launchFlexTemplate(request), expectedError);

test/gapic_jobs_v1_beta3_v1beta3.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,6 @@ describe('v1beta3.JobsV1Beta3Client', () => {
325325
new protos.google.dataflow.v1beta3.CreateJobRequest()
326326
);
327327
request.projectId = '';
328-
const expectedHeaderRequestParams = 'project_id=';
329328
const expectedError = new Error('The client has already been closed.');
330329
client.close();
331330
await assert.rejects(client.createJob(request), expectedError);
@@ -449,7 +448,6 @@ describe('v1beta3.JobsV1Beta3Client', () => {
449448
new protos.google.dataflow.v1beta3.GetJobRequest()
450449
);
451450
request.projectId = '';
452-
const expectedHeaderRequestParams = 'project_id=';
453451
const expectedError = new Error('The client has already been closed.');
454452
client.close();
455453
await assert.rejects(client.getJob(request), expectedError);
@@ -573,7 +571,6 @@ describe('v1beta3.JobsV1Beta3Client', () => {
573571
new protos.google.dataflow.v1beta3.UpdateJobRequest()
574572
);
575573
request.projectId = '';
576-
const expectedHeaderRequestParams = 'project_id=';
577574
const expectedError = new Error('The client has already been closed.');
578575
client.close();
579576
await assert.rejects(client.updateJob(request), expectedError);
@@ -801,7 +798,6 @@ describe('v1beta3.JobsV1Beta3Client', () => {
801798
new protos.google.dataflow.v1beta3.SnapshotJobRequest()
802799
);
803800
request.projectId = '';
804-
const expectedHeaderRequestParams = 'project_id=';
805801
const expectedError = new Error('The client has already been closed.');
806802
client.close();
807803
await assert.rejects(client.snapshotJob(request), expectedError);

test/gapic_metrics_v1_beta3_v1beta3.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,6 @@ describe('v1beta3.MetricsV1Beta3Client', () => {
330330
new protos.google.dataflow.v1beta3.GetJobMetricsRequest()
331331
);
332332
request.projectId = '';
333-
const expectedHeaderRequestParams = 'project_id=';
334333
const expectedError = new Error('The client has already been closed.');
335334
client.close();
336335
await assert.rejects(client.getJobMetrics(request), expectedError);

test/gapic_snapshots_v1_beta3_v1beta3.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ describe('v1beta3.SnapshotsV1Beta3Client', () => {
267267
new protos.google.dataflow.v1beta3.GetSnapshotRequest()
268268
);
269269
request.projectId = '';
270-
const expectedHeaderRequestParams = 'project_id=';
271270
const expectedError = new Error('The client has already been closed.');
272271
client.close();
273272
await assert.rejects(client.getSnapshot(request), expectedError);
@@ -394,7 +393,6 @@ describe('v1beta3.SnapshotsV1Beta3Client', () => {
394393
new protos.google.dataflow.v1beta3.DeleteSnapshotRequest()
395394
);
396395
request.projectId = '';
397-
const expectedHeaderRequestParams = 'project_id=';
398396
const expectedError = new Error('The client has already been closed.');
399397
client.close();
400398
await assert.rejects(client.deleteSnapshot(request), expectedError);
@@ -521,7 +519,6 @@ describe('v1beta3.SnapshotsV1Beta3Client', () => {
521519
new protos.google.dataflow.v1beta3.ListSnapshotsRequest()
522520
);
523521
request.projectId = '';
524-
const expectedHeaderRequestParams = 'project_id=';
525522
const expectedError = new Error('The client has already been closed.');
526523
client.close();
527524
await assert.rejects(client.listSnapshots(request), expectedError);

test/gapic_templates_service_v1beta3.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,6 @@ describe('v1beta3.TemplatesServiceClient', () => {
271271
new protos.google.dataflow.v1beta3.CreateJobFromTemplateRequest()
272272
);
273273
request.projectId = '';
274-
const expectedHeaderRequestParams = 'project_id=';
275274
const expectedError = new Error('The client has already been closed.');
276275
client.close();
277276
await assert.rejects(
@@ -401,7 +400,6 @@ describe('v1beta3.TemplatesServiceClient', () => {
401400
new protos.google.dataflow.v1beta3.LaunchTemplateRequest()
402401
);
403402
request.projectId = '';
404-
const expectedHeaderRequestParams = 'project_id=';
405403
const expectedError = new Error('The client has already been closed.');
406404
client.close();
407405
await assert.rejects(client.launchTemplate(request), expectedError);
@@ -528,7 +526,6 @@ describe('v1beta3.TemplatesServiceClient', () => {
528526
new protos.google.dataflow.v1beta3.GetTemplateRequest()
529527
);
530528
request.projectId = '';
531-
const expectedHeaderRequestParams = 'project_id=';
532529
const expectedError = new Error('The client has already been closed.');
533530
client.close();
534531
await assert.rejects(client.getTemplate(request), expectedError);

0 commit comments

Comments
 (0)