Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

chore(deps): pin @compodoc/compodoc version - #814

Merged
sofisl merged 1 commit into
googleapis:mainfrom
Drarig29:corentin.girard/pin-compodoc-version
Apr 26, 2024
Merged

sofisl merged 1 commit into
googleapis:mainfrom
Drarig29:corentin.girard/pin-compodoc-version

Conversation

@Drarig29

@Drarig29 Drarig29 commented Apr 26, 2024 •

Copy link
Copy Markdown
Contributor

This PR fixes the following CI error:

$ npm install --production --engine-strict --ignore-scripts --no-package-lock

npm WARN config production Use `--omit=dev` instead.
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: @angular-devkit/[email protected]
npm ERR! notsup Not compatible with your version of node/npm: @angular-devkit/[email protected]
npm ERR! notsup Required: {"node":"^18.13.0 || >=20.9.0","npm":"^6.11.0 || ^7.5.6 || >=8.0.0","yarn":">= 1.13.0"}
npm ERR! notsup Actual:   {"npm":"8.19.[4](https://github.com/googleapis/nodejs-common/actions/runs/8696396942/job/24212891011?pr=813#step:5:5)","node":"v16.20.2"}

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2024-04-24T1[6](https://github.com/googleapis/nodejs-common/actions/runs/8696396942/job/24212891011?pr=813#step:5:7)_36_23_094Z-debug-0.log

The latest version of @compodoc/compodoc (1.1.24) bumped the version of their @angular-devkit/schematics dependency, which doesn't support Node 16 anymore.

The solution is to pin @compodoc/compodoc to the last non-breaking patch version.

@Drarig29
Drarig29 requested a review from a team April 26, 2024 17:04
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Apr 26, 2024
@sofisl sofisl added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2024
@sofisl
sofisl merged commit 439185b into googleapis:main Apr 26, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Apr 26, 2024
@Drarig29
Drarig29 deleted the corentin.girard/pin-compodoc-version branch April 26, 2024 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants