This repository was archived by the owner on Mar 19, 2026. It is now read-only.
feat: add ignoreNotFound to service-object#delete#634
Merged
sofisl merged 5 commits intogoogleapis:masterfrom Nov 11, 2020
Merged
feat: add ignoreNotFound to service-object#delete#634sofisl merged 5 commits intogoogleapis:masterfrom
sofisl merged 5 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 7 7
Lines 2032 2046 +14
Branches 141 173 +32
=======================================
+ Hits 2006 2020 +14
Misses 26 26
Continue to review full report at Codecov.
|
bcoe
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards googleapis/nodejs-storage#1235