Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

feat: add ignoreNotFound to service-object#delete#634

Merged
sofisl merged 5 commits intogoogleapis:masterfrom
AVaksman:ignoreNotFound
Nov 11, 2020
Merged

feat: add ignoreNotFound to service-object#delete#634
sofisl merged 5 commits intogoogleapis:masterfrom
AVaksman:ignoreNotFound

Conversation

@AVaksman
Copy link
Copy Markdown
Contributor

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards googleapis/nodejs-storage#1235

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2020

Codecov Report

Merging #634 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files           7        7           
  Lines        2032     2046   +14     
  Branches      141      173   +32     
=======================================
+ Hits         2006     2020   +14     
  Misses         26       26           
Impacted Files Coverage Δ
src/service-object.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f85803...0839b53. Read the comment docs.

@AVaksman AVaksman marked this pull request as ready for review October 21, 2020 17:05
@AVaksman AVaksman requested a review from a team October 21, 2020 17:05
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2020
@sofisl sofisl merged commit 3248e27 into googleapis:master Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants