This repository was archived by the owner on Mar 19, 2026. It is now read-only.
fix!: remove support for custom promises#541
Merged
JustinBeckwith merged 1 commit intomasterfrom Mar 5, 2020
Merged
Conversation
googlebot
added
the
cla: yes
JustinBeckwith
requested review from
alexander-fenster,
bcoe and
stephenplusplus
bcoe
approved these changes
Mar 5, 2020
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This removes support for custom promises. When this feature was originally rolled out, promise support in node.js and the browser was somewhat inconsistent. Today, all supported versions of nodejs enjoy a consistent, performant implementation of promises. Explicitly removing this feature to ensure consistency.