Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

fix: teeny-request should be dependency#403

Merged
yoshi-automation merged 1 commit intomasterfrom
move-teeny
Apr 4, 2019
Merged

fix: teeny-request should be dependency#403
yoshi-automation merged 1 commit intomasterfrom
move-teeny

Conversation

@bcoe
Copy link
Copy Markdown

@bcoe bcoe commented Apr 4, 2019

Fixes issues seen here: googleapis/cloud-debug-nodejs#667

teeny-request is required in util.js, but is only currently present as a dev-dependency.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2019
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need adult supervision

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2019

Codecov Report

Merging #403 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files           5        5           
  Lines         336      336           
  Branches       50       50           
=======================================
  Hits          331      331           
  Misses          3        3           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86036e...9d00c74. Read the comment docs.

@callmehiphop callmehiphop added the automerge Merge the pull request once unit tests and other checks pass. label Apr 4, 2019
@yoshi-automation
Copy link
Copy Markdown
Contributor

Merged!

@yoshi-automation yoshi-automation merged commit 8bf66d4 into master Apr 4, 2019
@kjin
Copy link
Copy Markdown
Contributor

kjin commented Apr 8, 2019

Can we have a new release with this fix? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants