This repository was archived by the owner on Mar 19, 2026. It is now read-only.
fix: revert async behavior of request#331
Merged
JustinBeckwith merged 4 commits intogoogleapis:masterfrom Dec 13, 2018
JustinBeckwith:undo
Merged
fix: revert async behavior of request#331JustinBeckwith merged 4 commits intogoogleapis:masterfrom JustinBeckwith:undo
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
JustinBeckwith:undo
Conversation
googlebot
added
the
cla: yes
JustinBeckwith
added
do not merge
jkwlui
approved these changes
Dec 12, 2018
JustinBeckwith
removed
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I converted nodejs-common to TypeScript, I made the mistake of trying to make
requestandrequest_async functions. While we were able to fix most of the issues this caused, it had some unexpected results in nodejs-compute, where system tests have been broken for months. Going back to callbacks should fix this.Resolves #172