Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Package ent isn't maintained anymore, and using deprecated punycode #812

Closed

Description

@Drarig29

The ent package is still using the native punycode module which used to be bundled in Node.js < 21.

Starting in Node.js 21, this native module was deprecated (see official Node.js docs), and we now have to use the userland punycode.

And the following warning shows:

(node:1) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead. 

Since the latest version of ent is 9-years-old and the repository was removed from GitHub, I think we could replace ent with another heavily-used package, e.g. html-entities.

Environment details

  • OS: macOS
  • Node.js version: v21.7.3
  • npm version: 10.5.0
  • @google-cloud/common version: 5.0.1

Steps to reproduce

  1. npm install @google-cloud/common
  2. node --trace-deprecation -e "require('@google-cloud/common')" (on Node.js 21)

I'll make a PR.

Activity

  1. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Apr 15, 2024
  2. Drarig29 commented on Apr 15, 2024

    @Drarig29
    ContributorAuthor

    Solving this will close DataDog/datadog-ci#1283

  3. Drarig29 commented on Apr 26, 2024

    @Drarig29
    ContributorAuthor

    @sofisl Thanks for merging the PRs! 🙇

    Could you publish a patch release of @google-cloud/common? Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions